Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: processQueue never recovers from exceptions #34221

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: processQueue never recovers from exceptions #34221

wants to merge 2 commits into from

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 19, 2024 •
edited
Loading

…ing sync

if by any reason await Transport.send(message); processing never goes to false again, preventing processQueue to be processed, also since the message was being popped, the message was being "discarted"

using dispose we dont need to try/catch

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 19, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 87ae3d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34221/

Built to branch gh-pages at 2025-01-13 14:26 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.99%. Comparing base (0517a05) to head (87ae3d6).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #34221       +/-   ##
============================================
+ Coverage    59.12%   74.99%   +15.86%     
============================================
  Files         2819      516     -2303     
  Lines        67939    22746    -45193     
  Branches     15134     5518     -9616     
============================================
- Hits         40172    17059    -23113     
+ Misses       24934     5023    -19911     
+ Partials      2833      664     -2169
Flag Coverage Δ
e2e ?
e2e-api ?
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title fix: app queue fix: processQueue never recovers from exceptions Dec 20, 2024
@ggazzo ggazzo added this to the 7.2.0 milestone Dec 20, 2024
@ggazzo ggazzo marked this pull request as ready for review December 20, 2024 05:04
@ggazzo ggazzo requested a review from a team as a code owner December 20, 2024 05:04
@scuciatto scuciatto modified the milestones: 7.2.0, 7.3.0 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @scuciatto @d-gubert